Change EventList from Table subclass to attribute #754
Conversation
|
Please add a test for stacking event lists |
|
@adonath @joleroi I'm not done here adapting the code and test to the new EventList class, and the diff is already messy and hard to review. But maybe you can have a quick look at this class EventList(object):
def __init__(self, table):
self.table = tableAny comments? |
|
@cdeil I've had a quick look at the changes and I don't have any specific comments. I think introducing the |
| table = Table.read(str(filename), **kwargs) | ||
| return cls(table=table) | ||
|
|
||
| def info(self, file=None): |
There was a problem hiding this comment.
Please change this to __str__ (and add an info method calling it if you like). see http://docs.gammapy.org/en/latest/development/howto.html#object-summary-info-string
cdeil
changed the title
|
I've finished up this PR and updated the description above. |
|
The only fail is this: |
cdeil
changed the title
This pull request:
EventListfrom anastropy.table.Tablesub-class to a class with anastropy.table.Tableattribute.EventList.select_row_subsetmethod that dispatches toEventList.tableand is called everywhere row subset selection occurs.GTIfrom anastropy.table.Tablesub-class to a class with anastropy.table.Tableattribute.EventListtest with a Fermi-LAT event list (make some IACT-specific columns optional, e.g. in print output)EventListCheckerEventListEventListrelated code